Skip to content

feat(core): support stable Windows app selectors - #572

Open
markus41 wants to merge 1 commit into
AprilNEA:masterfrom
markus41:feat/windows-exe-profile-selectors
Open

feat(core): support stable Windows app selectors#572
markus41 wants to merge 1 commit into
AprilNEA:masterfrom
markus41:feat/windows-exe-profile-selectors

Conversation

@markus41

Copy link
Copy Markdown

Summary

  • recognize exe:.exe as a stable Windows per-application selector fallback
  • retain exact-path precedence when both selector forms exist
  • document the selector for Store and self-updating applications

Direct validation

  • cargo +1.96.0 build -p openlogi-core passed
  • cargo +1.96.0 fmt --check passed
  • openlogi-core loaded a schema-v3 config and matched exe:sharex.exe against a synthetic future versioned WindowsApps path while preserving Back=Copy and Forward=Paste

A full workspace build was not used as evidence because this workstation lacks the C++ vcruntime headers needed by ring; the focused core target is the changed closure.

@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adds stable executable-name fallback selectors for Windows per-application bindings while preserving exact-path precedence.

  • Routes effective-binding and override-presence lookups through a shared selector resolver.
  • Resolves lower-cased Windows executable paths against exe:<filename>.exe keys.
  • Documents the selector syntax and adds a configuration example.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issue identified.

Exact application identifiers retain precedence, Windows foreground paths are normalized consistently with the new executable fallback, and unchanged identifiers continue using the prior exact-match behavior.

Important Files Changed

Filename Overview
crates/openlogi-core/src/config.rs Adds a shared executable-selector fallback to effective binding and override-presence lookups while retaining exact-key precedence; no actionable defect was established.
docs/CONFIGURATION.md Documents the stable Windows selector syntax, precedence behavior, and a representative TOML configuration.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Foreground application identifier] --> B{Exact overlay exists?}
  B -- Yes --> C[Use exact overlay]
  B -- No --> D{Identifier ends with .exe?}
  D -- No --> E[Use global bindings]
  D -- Yes --> F[Extract and lowercase filename]
  F --> G{exe:filename overlay exists?}
  G -- Yes --> H[Use executable fallback overlay]
  G -- No --> E
Loading

Reviews (1): Last reviewed commit: "feat(core): support stable Windows app s..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant