feat(core): support stable Windows app selectors - #572
Open
markus41 wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR adds stable executable-name fallback selectors for Windows per-application bindings while preserving exact-path precedence.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issue identified. Exact application identifiers retain precedence, Windows foreground paths are normalized consistently with the new executable fallback, and unchanged identifiers continue using the prior exact-match behavior.
|
| Filename | Overview |
|---|---|
| crates/openlogi-core/src/config.rs | Adds a shared executable-selector fallback to effective binding and override-presence lookups while retaining exact-key precedence; no actionable defect was established. |
| docs/CONFIGURATION.md | Documents the stable Windows selector syntax, precedence behavior, and a representative TOML configuration. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Foreground application identifier] --> B{Exact overlay exists?}
B -- Yes --> C[Use exact overlay]
B -- No --> D{Identifier ends with .exe?}
D -- No --> E[Use global bindings]
D -- Yes --> F[Extract and lowercase filename]
F --> G{exe:filename overlay exists?}
G -- Yes --> H[Use executable fallback overlay]
G -- No --> E
Reviews (1): Last reviewed commit: "feat(core): support stable Windows app s..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direct validation
A full workspace build was not used as evidence because this workstation lacks the C++ vcruntime headers needed by ring; the focused core target is the changed closure.