ci(release): pin tags and fill changelog - #533
Merged
davidbudnick merged 3 commits intoAug 9, 2026
Merged
Conversation
Greptile SummaryThe PR moves root changelog generation to git-cliff and restricts release publishing to release commits or manual dispatches.
Confidence Score: 4/5The PR does not yet appear safe to merge because manual recovery can still publish and tag a different source tree than the selected failed release commit. The release job discards the event checkout and searches history by version, while repository history contains duplicate release commits for the same version; recovery can therefore select a newer matching commit and publish different code. Files Needing Attention: .github/workflows/release-plz.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/release-plz.yml | Adds changelog generation and release-source checkout, but the previously reported version-only commit lookup remains ambiguous when history contains multiple release commits for one version. |
| cliff.toml | Defines whole-repository conventional-commit filtering and Keep-a-Changelog rendering for git-cliff. |
| release-plz.toml | Transfers changelog ownership away from release-plz and prevents unconditional publishing from later master commits. |
| scripts/release/write-changelog.sh | Replaces the fingerprint-based augmentation helper with deterministic regeneration of the current version section, resolving the prior non-PR fingerprint duplication mechanism. |
Sequence Diagram
sequenceDiagram
participant RP as release-plz PR job
participant Cliff as git-cliff
participant Branch as Release PR branch
participant Master as master
participant Release as release job
RP->>Cliff: "Generate notes since latest v* tag"
Cliff-->>RP: Updated CHANGELOG.md
RP->>Branch: Commit and push changelog
Branch->>Master: Merge release PR
Master->>Release: Trigger on release commit
Release->>Release: Locate version-bump commit
Release->>Release: Publish crates and create tag
Reviews (3): Last reviewed commit: "refactor(release): use git-cliff for who..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops release-plz from tagging a late
mastertip after a failed publish, and fills the root changelog with every release-worthy commit since the last tag (including gui/agent-only work that package-scoped release-plz drops).Changes
release_always = falseso publish/tag only runs when the release PR mergesreleasejob onchore: release*/workflow_dispatch, and check out the version-bump commit before taggingrelease-pr, merge allfeat|fix|perfsubjects since the lastv*tag intoCHANGELOG.md(coversrelease = falseapp crates that cannot usechangelog_include/git_only)Testing
Not runtime-tested as a full GitHub Actions publish/tag (crates.io token path out of scope).
Notes
Leave #509 open; after this lands on master the bot will refresh it and the augment step will fill the missing entries.