[Fix] 프로젝트 명칭 형식 제한 문제 해결 #5 - #44
Merged
Merged
Conversation
Member
|
해당 pr도 문제가 없다면 드래프트를 풀어주세요 |
callme-waffle
marked this pull request as ready for review
June 21, 2026 23:05
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dea77626a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 변경 요약 (Summary)
-만 허용하도록 제한했습니다.🔗 관련 이슈 (Related Issue)
Closes #5
🛠 작업 내용 / 작업 순서 (Implementation Details)
ProjectNameValidator추가로 프로젝트명 검증 규칙 중앙화✨ 주요 변경 사항 (Key Changes)
^[a-z0-9-]+$ACC-PROJECT-INVALID-PROJECT-NAMEPOST /api/v1/projects/requestPOST /api/v1/admin/projectsProjectModule.createProject🧪 테스트 결과 (Test Results)
테스트 환경
http://127.0.0.1:8080aolda-issue1-mariadbMariaDB 컨테이너aolda-test-redisRedis 컨테이너SessionData를 직접 생성하고acc-session-id쿠키로 API 호출테스트 방법
자동 테스트 실행
./gradlew test --tests com.acc.local.service.modules.auth.ProjectModuleTest --tests com.acc.local.service.adapters.project.AdminProjectServiceAdapterTestBUILD SUCCESSFUL전체 자동 테스트 실행
./gradlew testBUILD SUCCESSFUL테스트 환경 기동 확인
bootRun실행/actuator/health호출로UP확인Redis 테스트 세션 생성
SessionData생성acc-session-id=issue5-project-name-test쿠키로 API 호출프로젝트 요청 생성 invalid name 테스트
POST /api/v1/projects/requestprojectName=Invalid_Project400ACC-PROJECT-INVALID-PROJECT-NAME관리자 프로젝트 직접 생성 invalid name 테스트
POST /api/v1/admin/projectsprojectName=Invalid_Project400ACC-PROJECT-INVALID-PROJECT-NAME프로젝트 요청 생성 valid name 테스트
POST /api/v1/projects/requestprojectName=issue5-valid-project-20260619-001201projectRequestId=c292089c-f26f-4e9d-876f-2d6edd7a12e3테스트 리소스 정리 검증
project_requests테스트 데이터 삭제outbox_events테스트 데이터 삭제테스트 결과
검증 결과 요약:
참고: #5 변경의 핵심은 invalid 프로젝트명이 OpenStack API로 전달되기 전에 차단되는지입니다. 따라서 valid 관리자 직접 생성으로 실제 Keystone/Neutron 리소스를 생성하는 테스트는 수행하지 않았습니다.