Repository navigation
feat: introduce Alias class for handling request parameter aliases. - #938
Open
renatodamas wants to merge 15 commits into
Open
renatodamas wants to merge 15 commits into
renatodamas wants to merge 15 commits into
Conversation
…nto feat/kebab-routers-parameters # Conflicts: # fasthtml/core.py # nbs/api/00_core.ipynb
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #937 (feature request: kebab-case / aliased request parameters).
Proposed Changes
Adds an opt-in
Aliasmarker so handler parameters can read request data under a different name, e.g.:Changes in nbs/api/00_core.ipynb (source for fasthtml/core.py):
• New Alias dataclass, exported via fasthtml.common.
• find_p unwraps Annotated[T, ...] and uses the alias for path, cookie, query, form, htmx values, and header lookups (headers default to snake2hyphens when no alias is set).
• Missing-field errors report the alias name.
Parameters without Alias behave exactly as before.
Validation: tests/test_alias.py 9/9 pass. Full suite: 13 passed, 1 failed. test_toaster.py::test_get_toaster_with_typehint also fails on main, so it is pre-existing.
Types of changes
Checklist
Go over all the following points, and put an
xin all the boxes that apply: