Repository navigation
ci: run installed-package consumer checks before publish - #794
Open
cindybby18 wants to merge 1 commit into
Open
cindybby18 wants to merge 1 commit into
cindybby18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR runs the Bun and Node consumer fixtures against the packed artifact in CI and before publication, so a broken runtime import or declaration fails the consumer job instead of reaching npm.
Related Issue
Closes #AK-006
Changes
.github/workflows/ci.yml.github/workflows/publish.ymlscripts/check-package-consumer.mjsfixtures/consumer/package.jsonfixtures/consumer/verify.mjsVerification Results
Expected result: the script packs the SDK, installs the tarball into
fixtures/consumer, runsverify.mjsunder both Bun and Node, and exits 0. Introducing a broken runtime import or a missing declaration causes the script to exit non-zero, which fails the consumer job before publication.node scripts/check-package-consumer.mjswith expected result aboveCloses #694