Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a typed account lookup boundary so SEP-10 authentication can read configured account signers, weights, and thresholds instead of requiring the account master key. The lookup returns distinct not-found and upstream-error outcomes, and the HTTP handling in the Express router now distinguishes them.
Related Issue
Closes #AK-028
Changes
[MODIFY]
src/runtime/interfaces.ts[MODIFY]
src/runtime/http/express-router-impl.ts[MODIFY]
src/runtime/http/express-router.ts[MODIFY]
src/services/stellar-signer.tsVerification Results
Focused check (fixtures for existing, nonexistent, and unavailable accounts; no real credentials):
Expected result: the existing-account, nonexistent-account, and unavailable-account cases pass, with not-found and upstream-error responses asserted as distinct.
Type and build checks:
npm test -- src/runtime/httpCloses #704