Skip to content

Implement acceptance gates for issues 669 690 689 691 - #766

Merged
0xNgoo merged 4 commits into
Anchor-kit:mainfrom
augustine0956:issues/669-690-689-691-acceptance-gates
Oct 23, 2026
Merged

0xNgoo merged 4 commits into
Anchor-kit:mainfrom
augustine0956:issues/669-690-689-691-acceptance-gates

Conversation

@augustine0956

Copy link
Copy Markdown
Contributor

What does this PR do?

Implements the acceptance gates for #669, #690, #689, and #691:

  • Preserves queue maxPendingJobs and onError through configuration resolution, validates both settings, and passes them to the in-memory adapter. Adds public-factory coverage for queue limits and worker error handling.
  • Updates protocol stub READMEs and implementation status to distinguish existing HTTP and plugin infrastructure from complete SEP protocol support.
  • Makes the Node-targeted package bundle internal source aliases correctly and loads Bun SQLite only when SQLite is selected. Adds a clean Node tarball consumer smoke test for public import, PostgreSQL migration, /health, and shutdown, and wires it into CI with PostgreSQL 16.
  • Adds ordered, transactional core and plugin database migrations, applied-migration tracking, legacy schema adoption, and retry/rollback coverage. Documents the migration contract and focused check.

How to test?

  • bun test — expected: 864 tests pass.
  • bun test tests/core/factory-background-startup.test.ts tests/readme-protocol-status.test.ts tests/runtime/database/versioned-migrations.test.ts tests/runtime/database/migrate-single-flight.test.ts tests/runtime/sqlite-wal-concurrency.test.ts — expected: 23 tests pass.
  • bun run build and bun x tsc --noEmit — expected: both succeed.
  • On Node 22 with a disposable PostgreSQL database, run bun run smoke:node-postgres — expected: it prints Node PostgreSQL package smoke passed: public import, migration, HTTP /health, and shutdown. CI runs this against its PostgreSQL service.

Checklist

  • Added focused tests for the changes.
  • Updated related documentation and documented reproducible focused checks.
  • Ran the full test suite, build, type check, changed-code lint, and formatting checks.
  • Ran the PostgreSQL package smoke test locally; CI is configured to run it.

Issue Reference

Closes #669
Closes #690
Closes #689
Closes #691

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@augustine0956 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@0xNgoo

0xNgoo commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Correction: I verified maintainer edits are enabled for this PR. I’ll resolve the conflict and Node PostgreSQL smoke-test failure on the existing branch as 0xNgoo, preserving your PR and issue attribution. Please disregard my request for you to push the fix.

@0xNgoo
0xNgoo merged commit ee6597e into Anchor-kit:main Oct 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants