Repository navigation
fix(win): build with MinGW-w64 and on case-sensitive filesystems - #22
Open
ssuyash3000 wants to merge 1 commit into
Open
ssuyash3000 wants to merge 1 commit into
ssuyash3000 wants to merge 1 commit into
Conversation
The Windows target only ever built under MSVC: - `#include <BluetoothAPIs.h>` — the MinGW-w64 header is `bluetoothapis.h`, and the case also matters when cross-compiling from a case-sensitive filesystem. - `#pragma comment(lib, ...)` is MSVC-only, so ws2_32/rpcrt4/bthprops were never linked anywhere else: ~25 undefined references to closesocket, WSAStartup, UuidFromStringA, BluetoothFindFirstRadio and friends. - `#include "Windows.h"` in WindowsGUI.h fails the same way. Link the import libraries from CMake instead, keep the pragmas for MSVC only, and move NOMINMAX/WIN32_LEAN_AND_MEAN to the target so every translation unit gets them, not just CrossPlatformGUI.cpp. Verified by cross-compiling the Windows target with x86_64-w64-mingw32-g++ 13. MSVC is unaffected: it keeps both the pragmas and the CMake libraries. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows target only ever built under MSVC:
#include <BluetoothAPIs.h>— the MinGW-w64 header isbluetoothapis.h, andthe case also matters when cross-compiling from a case-sensitive filesystem.
#pragma comment(lib, ...)is MSVC-only, so ws2_32/rpcrt4/bthprops were neverlinked anywhere else: ~25 undefined references to closesocket, WSAStartup,
UuidFromStringA, BluetoothFindFirstRadio and friends.
#include "Windows.h"in WindowsGUI.h fails the same way.Link the import libraries from CMake instead, keep the pragmas for MSVC only,
and move NOMINMAX/WIN32_LEAN_AND_MEAN to the target so every translation unit
gets them, not just CrossPlatformGUI.cpp.
Verified by cross-compiling the Windows target with x86_64-w64-mingw32-g++ 13.
MSVC is unaffected: it keeps both the pragmas and the CMake libraries.