Repository navigation
fix(ui): upload device hero images so they actually render - #20
Open
ssuyash3000 wants to merge 1 commit into
Open
ssuyash3000 wants to merge 1 commit into
ssuyash3000 wants to merge 1 commit into
Conversation
`_deviceTexture()` pushed the freshly created `ImTextureData` straight into `ImGui::GetPlatformIO().Textures`, but `UpdateTexturesEndFrame()` resizes that list to 0 each frame and refills it from the font atlases plus the registered user textures. The entry was therefore gone before the renderer backend could honour `ImTextureStatus_WantCreate`, and the texture was never uploaded: - Release: the product image area is blank; every device falls back to nothing. - Debug: `IM_ASSERT(tex_id != ImTextureID_Invalid && "ImDrawCmd is referring to ImTextureData that wasn't uploaded to graphics system...")` fires. `ImGui::RegisterUserTexture()` (imgui 1.92+) adds it to `g.UserTextures`, which is what the per-frame rebuild reads from, so the upload request survives. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_deviceTexture()pushed the freshly createdImTextureDatastraight intoImGui::GetPlatformIO().Textures, butUpdateTexturesEndFrame()resizes thatlist to 0 each frame and refills it from the font atlases plus the registered
user textures. The entry was therefore gone before the renderer backend could
honour
ImTextureStatus_WantCreate, and the texture was never uploaded:IM_ASSERT(tex_id != ImTextureID_Invalid && "ImDrawCmd is referring to ImTextureData that wasn't uploaded to graphics system...")fires.ImGui::RegisterUserTexture()(imgui 1.92+) adds it tog.UserTextures, whichis what the per-frame rebuild reads from, so the upload request survives.