Repository navigation
fix(ui): refresh the battery level while connected - #19
Open
ssuyash3000 wants to merge 1 commit into
Open
ssuyash3000 wants to merge 1 commit into
ssuyash3000 wants to merge 1 commit into
Conversation
`requestBattery()` only runs in the post-connect read, so the percentage in the header is a snapshot from the moment you pressed Connect. Leave the app open for a few hours and it still shows that first value while the real headset drains — and on a charging headset it never climbs. Piggyback a battery read on the existing ambient poll worker, once every ~30s (`BATTERY_POLL_FRAMES`), so no extra thread or future is needed. The read is guarded: a device that doesn't answer the inquiry keeps its stale value instead of dropping the poll. Verified against a simulated v2 device whose reported level changes over time: the header follows it instead of freezing at the connect-time value. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestBattery()only runs in the post-connect read, so the percentage in theheader is a snapshot from the moment you pressed Connect. Leave the app open
for a few hours and it still shows that first value while the real headset
drains — and on a charging headset it never climbs.
Piggyback a battery read on the existing ambient poll worker, once every ~30s
(
BATTERY_POLL_FRAMES), so no extra thread or future is needed. The read isguarded: a device that doesn't answer the inquiry keeps its stale value instead
of dropping the poll.
Verified against a simulated v2 device whose reported level changes over time:
the header follows it instead of freezing at the connect-time value.