Repository navigation
fix(ui): manual EQ sliders cover the full -10..+10 range - #18
Open
ssuyash3000 wants to merge 1 commit into
Open
ssuyash3000 wants to merge 1 commit into
ssuyash3000 wants to merge 1 commit into
Conversation
The custom-EQ sliders were limited to 0..10, so every band could only be boosted — cutting a band was impossible from the Windows/Linux UI, and a negative value read back from the headphones (`requestEqualizer()` decodes `byte - 10`) was clamped to 0 by the widget and pushed back on the next edit. Both ends of the protocol already use the signed range: `setEqualizerCustom()` clamps to [-10, 10] and sends `value + 10`. The macOS UI uses -10...10 too, so this also makes the two interfaces agree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom-EQ sliders were limited to 0..10, so every band could only be
boosted — cutting a band was impossible from the Windows/Linux UI, and a
negative value read back from the headphones (
requestEqualizer()decodesbyte - 10) was clamped to 0 by the widget and pushed back on the next edit.Both ends of the protocol already use the signed range:
setEqualizerCustom()clamps to [-10, 10] and sends
value + 10. The macOS UI uses -10...10 too, sothis also makes the two interfaces agree.