Repository navigation
fix(amazonq): honor agentic OFF state across chat lifecycle - #2905
Open
laileni-aws wants to merge 1 commit into
Open
laileni-aws wants to merge 1 commit into
laileni-aws wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The agentic coding switch can display OFF while the server session remains ON. Tab creation initializes server mode from a global preference, while history restoration applies the saved per-tab mode only to the UI. The displayed mode included in normal prompt submissions was not consumed by the server. Early mode changes could also be lost before the history database finished loading.
Separately, a tool could pass its initial mode check and still dispatch after the user switched OFF during an asynchronous permission check or approval wait.
Related public report: Amazon-Q-Developer/amazon-q-vscode#160
Solution
trueenables it.Scope: seven files in
server/aws-lsp-codewhisperer. No dependency or deployment changes.Testing
npm run compile: passed with Node 22.16.0 and Node 24.13.0.agenticChat/**/*.test.tsandchat/**/*.test.tsdirectories on Node 24.13.0: 1,252 passing, 9 pending, with normal runner completion.git diff --check: passed.auto-cr-reviewer: all seven files and 28 hunks reviewed through the structured diff parser, followed by deduplication, confidence, compliance, and refinement passes. No actionable findings. No repository custom rules were present.Node 24 checks ran in a local Amazon Linux container with networking disabled and an isolated home directory because the host glibc cannot launch the official Node 24 binary.
Verification limits / handoff
ProfileStatusMonitorassertion. The Node 24 invocation exited successfully without a completion summary; existingprocess.exit(0)calls in unrelated test files can terminate that run early. The completed chat-directory run above is the broader verified result.Draft only. No reviewers requested. Human review and IDE integration validation remain before publication or merge.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.