Skip to content

feat: persist chat deprecation acknowledgement - #209

Merged
araarush merged 4 commits into
Amazon-Q-Developer:mainfrom
araarush:feature/deprecation-chat-persistence
Sep 29, 2026
Merged

araarush merged 4 commits into
Amazon-Q-Developer:mainfrom
araarush:feature/deprecation-chat-persistence

Conversation

@araarush

@araarush araarush commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The shared Amazon Q chat client emits an acknowledgement when the IDE end-of-support notice is dismissed, but VS Code did not persist or return that acknowledgement. Without client-side state, the notice can return after the extension host restarts.

Companion shared-client change: Amazon-Q-Developer/language-servers#2877.

Solution

  • Add a dedicated amazonQChatDeprecationNotice suppression setting.
  • Pass deprecationNoticeAcknowledged to the shared chat client when creating the webview.
  • Persist acknowledgements for the client-deprecation-notice message ID.
  • Keep this state independent from the previous pair-programming feature card.
  • Add unit coverage for acknowledged and unacknowledged initialization and dismissal handling.

Validation

  • Focused Amazon Q chat unit suite: 11 passing.
  • Tested with production-shaped local Flare manifest version 1.79.924.
  • Verified the notice appears in new chats before acknowledgement.
  • Verified dismissal is reflected across open and future chats.
  • Verified dismissal remains persisted after a complete VS Code process restart.

Video

Screen.Recording.2026-09-23.at.12.03.53.PM.mov

  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@araarush araarush changed the title feat(amazonq): persist chat deprecation acknowledgement feat: persist chat deprecation acknowledgement Sep 24, 2026
@araarush araarush closed this Sep 24, 2026
@araarush araarush reopened this Sep 24, 2026
@araarush
araarush marked this pull request as ready for review September 24, 2026 22:44
@araarush
araarush requested a review from a team as a code owner September 24, 2026 22:44
@dungdong-aws

Copy link
Copy Markdown

nit: can we have some acknowledge button a pop-up instead of silently acknowledge through X

@araarush

Copy link
Copy Markdown
Contributor Author

On the acknowledgement behavior: Product confirmed that the X is the shared dismissal behavior across all IDEs. It is an explicit user action: Mynah emits the shared client-deprecation-notice acknowledgement, and each IDE client persists that same dismissal so the notice stays hidden across restarts. Adding a separate button or pop-up in VS Code would diverge from the product-approved cross-client behavior.

@dungdong-aws

Copy link
Copy Markdown

sgtm!

@araarush
araarush merged commit e31e451 into Amazon-Q-Developer:main Sep 29, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants