Repository navigation
Conversation
araarush
marked this pull request as ready for review
September 24, 2026 22:44
dungdong-aws
approved these changes
Sep 25, 2026
|
nit: can we have some acknowledge button a pop-up instead of silently acknowledge through |
chungjac
approved these changes
Sep 25, 2026
laileni-aws
reviewed
Sep 28, 2026
Contributor
Author
|
On the acknowledgement behavior: Product confirmed that the X is the shared dismissal behavior across all IDEs. It is an explicit user action: Mynah emits the shared |
|
sgtm! |
dungdong-aws
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared Amazon Q chat client emits an acknowledgement when the IDE end-of-support notice is dismissed, but VS Code did not persist or return that acknowledgement. Without client-side state, the notice can return after the extension host restarts.
Companion shared-client change: Amazon-Q-Developer/language-servers#2877.
Solution
amazonQChatDeprecationNoticesuppression setting.deprecationNoticeAcknowledgedto the shared chat client when creating the webview.client-deprecation-noticemessage ID.Validation
1.79.924.Video
Screen.Recording.2026-09-23.at.12.03.53.PM.mov