feat: consume upstream react-native-screens nested-scroll seam - #27
Draft
AmatoGiulio wants to merge 9 commits into
Draft
feat: consume upstream react-native-screens nested-scroll seam#27AmatoGiulio wants to merge 9 commits into
AmatoGiulio wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Consume the neutral Android nested-scroll delegate seam prototyped in
AmatoGiulio/react-native-screens#1without making react-native-screens depend on this package.The goal is the generic transport path, not the Material3 reference UI.
Design
ReactNativeScreenNestedScrollBridgeas the implementation;ScreenNestedScrollInterop.kt;com.swmansion.rnscreens;check:package-surface;ScreensCoordinatorLayout+ new StackStackHeaderCoordinatorLayout, rather than patchingScreendirectly.Upstream ownership
The screens prototype always runs react-native-screens' existing CoordinatorLayout/AppBar/BottomSheet behavior first. This package receives only the nested-scroll distance still available afterward. React Native remains the source touch/position/fling owner.
Validation
react-native-scroll-interop+ forkedreact-native-screensKotlin compile in a bare RN consumer: PASSNativeScrollHostaround the screen;ReactNestedScrollViewbound through the screens seam;topBar=trueand transaction becomesactive=true;momentum-stop;broken=0;The debug ledger also reports some
orphanPreentries where React Native emits a PRE callback without a corresponding POST callback. These are counted separately and are not broken completed frames; all completed frames in the runtime proof remained balanced (broken=0).This PR remains draft and is not intended for merge or publish until an official react-native-screens release contains the seam. No version change and no npm publish.