Antalya 25.8: Bump to 25.8.33 - #2287
Check failed
There are 29 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🔴 | d42ef29 | Backport ClickHouse#99366 to 25.8: Fix data race between Bac... | Sign-off not found |
| 🔴 | 8644786 | Backport ClickHouse#113563 to 25.8: Do not analyze the share... | Sign-off not found |
| 🟢 | 55e535f | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🟢 | 950b78b | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🟢 | c8825fd | Merge pull request ClickHouse#114307 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | c5c8d19 | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🔴 | 9e7981d | Backport ClickHouse#94748 to 25.8: Fix invalid result of joi... | Sign-off not found |
| 🔴 | 9b81a35 | Backport ClickHouse#108329 to 25.8: Bump libssh to 0.12.0 |
Sign-off not found |
| 🔴 | 4f55556 | Backport ClickHouse#107028 to 25.8: Fix data race on FileCac... | Sign-off not found |
| 🔴 | 05c4b0f | Backport ClickHouse#113742 to 25.8: Skip the custom-key para... | Sign-off not found |
| 🟢 | 052170c | Merge pull request ClickHouse#114621 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 1d70919 | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🔴 | 1e0a169 | Fix query limit tests in 25.8 backport | Sign-off not found |
| 🔴 | a05bc7f | Backport ClickHouse#114668 to 25.8: Stop Parquet background ... | Sign-off not found |
| 🟢 | 780d6d6 | Merge remote-tracking branch 'origin/25.8' into co... | Skipped: sign-off not required in merge commit |
| 🔴 | 2407bc4 | Fix S3Queue regression test processing path |
Sign-off not found |
| 🟢 | 1e63710 | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🔴 | 2a1e5f7 | Fix Parquet dictionary prefetch test in 25.8 backp... | Sign-off not found |
| 🔴 | 8b43ee5 | Make S3Queue regression setup deterministic |
Sign-off not found |
| 🔴 | bfb9089 | Fix invalid Parquet dictionary prefetch test oracl... | Sign-off not found |
| 🟢 | ab54dd9 | Merge pull request ClickHouse#114804 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 1ae77ba | Merge pull request ClickHouse#114761 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | c14be15 | Merge remote-tracking branch 'origin/25.8' into co... | Skipped: sign-off not required in merge commit |
| 🟢 | ca79ec8 | Merge branch 25.8 into backport/25.8/114668 | Skipped: sign-off not required in merge commit |
| 🔴 | e5a03eb | Fix Parquet dictionary regression test path | Sign-off not found |
| 🔴 | ffeb2fc | Backport ClickHouse#87838 to 25.8: unlink METADATA_VERSION_F... | Sign-off not found |
| 🔴 | 980e973 | Backport ClickHouse#111378 to 25.8: Fsync restored part file... | Sign-off not found |
| 🔴 | 8ca297d | Update autogenerated version to 25.8.30.16 and con... | Sign-off not found |
| 🟢 | fedec06 | Merge remote-tracking branch 'origin/25.8' into co... | Skipped: sign-off not required in merge commit |
| 🔴 | dd18559 | Do not read the master-only system.parts.files col... | Sign-off not found |
| 🟢 | ac66b78 | Merge remote-tracking branch 'origin/25.8' into HE... | Skipped: sign-off not required in merge commit |
| 🟢 | 7aa8d32 | Merge remote-tracking branch 'origin/25.8' into HE... | Skipped: sign-off not required in merge commit |
| 🟢 | 49d11b7 | Merge pull request ClickHouse#114927 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 3251360 | Merge pull request ClickHouse#115088 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 543ead1 | Merge pull request ClickHouse#115009 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | a9c176e | Merge remote-tracking branch 'origin/25.8' into HE... | Skipped: sign-off not required in merge commit |
| 🔴 | bbfad95 | Fix use-after-free on a sparse join key in a direc... | Sign-off not found |
| 🟢 | 95bde92 | Merge pull request ClickHouse#114699 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🔴 | 77b6ebb | Backport ClickHouse#115227 to 25.8: Do not use the trivial c... | Sign-off not found |
| 🟢 | c6b48ef | Merge pull request ClickHouse#114295 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🔴 | 6fbabf8 | Backport ClickHouse#100283 to 25.8: Validate Iceberg metadat... | Sign-off not found |
| 🔴 | 0713259 | Drop the unnest arms from `04743_trivial_count_a... |
Sign-off not found |
| 🟢 | 13b56c7 | Merge pull request ClickHouse#114814 from groeneai/groeneai/... | Skipped: sign-off not required in merge commit |
| 🟢 | 7b7f6ff | Merge pull request ClickHouse#115468 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🔴 | 075b316 | Backport ClickHouse#115466 to 25.8: Do not strip injective f... | Sign-off not found |
| 🟢 | f09bf39 | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🔴 | 4629755 | Update autogenerated version to 25.8.31.9 and cont... | Sign-off not found |
| 🔴 | 9ee31bb | Backport ClickHouse#115669 to 25.8: Fix out-of-bounds read i... | Sign-off not found |
| 🔴 | 4c75d63 | upd 04927_uniq_injective_tuple_nullable | Sign-off not found |
| 🔴 | ba7b685 | Update autogenerated version to 25.8.32.4 and cont... | Sign-off not found |
| 🟢 | 97a74b5 | Merge pull request ClickHouse#115727 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 23fd7ca | Merge pull request ClickHouse#115598 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🔴 | 86f3689 | Backport ClickHouse#114624 to 25.8: Find a LowCardinality ne... | Sign-off not found |
| 🟢 | 7c803d9 | Merge pull request ClickHouse#115495 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🔴 | 4f312f2 | Drop the plain-array oracle of the FixedString-nee... | Sign-off not found |
| 🟢 | 65d8983 | Merge remote-tracking branch 'origin/25.8' into ba... | Skipped: sign-off not required in merge commit |
| 🔴 | dd491bf | Backport ClickHouse#115704 to 25.8: Do not expose uninitiali... | Sign-off not found |
| 🟢 | 9adaa1a | Merge pull request ClickHouse#116240 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 65eaf18 | Merge pull request ClickHouse#115918 from ClickHouse/backpor... | Skipped: sign-off not required in merge commit |
| 🟢 | 448d1c1 | Merge tag 'v25.8.33.6-lts' into bump/antalya-25.8/... | Skipped: sign-off not required in merge commit |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~60 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin bump/antalya-25.8/25.8.33