Parquet: read-path redesign — serve bytes as they arrive, bounded coalescing, lifetime memory pools, read-ahead controller, filesystem-cache fixes - #2275
Check failed
There are 5 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | b43afbe | Parquet: design spec and implementation plan for t... | Valid sign-off found |
| 🟢 | a88e21f | Parquet: derive the IO pool size from the query an... | Valid sign-off found |
| 🟢 | c6583f1 | Parquet read-path spec: fold in the vig-test measu... | Valid sign-off found |
| 🟢 | 9d28162 | Parquet read-path spec: rewrite §4.2c as alignmen... | Valid sign-off found |
| 🟢 | 6c84dba | Parquet read-path plan: re-cut Tasks 4-11 for the ... | Valid sign-off found |
| 🟢 | c30c6c1 | Parquet: serve a coalesced read's bytes as they ar... | Valid sign-off found |
| 🟢 | 2b241cc | Parquet read-path plan: state the readBigAt progre... | Valid sign-off found |
| 🟢 | 3143a37 | Parquet: fix zero-copy readiness race and use a wa... | Valid sign-off found |
| 🟢 | 59a06a1 | Parquet: test that decoding starts on a coalesced ... | Valid sign-off found |
| 🟢 | 45c338a | Filesystem cache: honour the per-query boundary al... | Valid sign-off found |
| 🟢 | 54b68f7 | Filesystem cache: let a reader opt out of backgrou... | Valid sign-off found |
| 🟢 | 2e47a7c | Parquet: bound read amplification and cap the coal... | Valid sign-off found |
| 🟢 | 5e81472 | Parquet: budget reader memory by lifetime (metadat... | Valid sign-off found |
| 🟢 | 5daead9 | Parquet: fix Metadata-pool circular wait and text ... | Valid sign-off found |
| 🟢 | 022be55 | Parquet: keep delivered chunks charged to the read... | Valid sign-off found |
| 🟢 | 6359ea2 | Parquet: address review on delivered-chunk memory ... | Valid sign-off found |
| 🟢 | 8afc8e8 | Parquet: measure per-read first-byte time and band... | Valid sign-off found |
| 🟢 | 7d9fd18 | Parquet: fix bandwidth pollution from non-progress... | Valid sign-off found |
| 🟢 | aae109d | Parquet: pre-issue index and page reads for all ro... | Valid sign-off found |
| 🟢 | 43da7c2 | Parquet: keep read-ahead inside the memory cap, ma... | Valid sign-off found |
| 🟢 | 8e77daf | Parquet: make the filesystem cache's readBigAt pro... | Valid sign-off found |
| 🟢 | 6dad4c2 | Parquet: cover partial readiness on the filesystem... | Valid sign-off found |
| 🔴 | 2870a61 | Parquet: count only executing bytes against the re... | Sign-off not found |
| 🔴 | 619efb8 | Parquet: bound read amplification by absolute wast... | Sign-off not found |
| 🔴 | 747a6c7 | Parquet: read through gaps the source already has ... | Sign-off not found |
| 🔴 | d064c0b | Page cache: read through short islands of cached b... | Sign-off not found |
| 🔴 | 6503da0 | Parquet: relax the read-amplification floor test's... | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~27 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin parquet-v3-read-sizing