Fix cluster functions with hive partitioning#1863
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8cc3a0eb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9850be48c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
|
||
| NamesAndTypesList IStorageCluster::getHivePartitionColumnsWithoutVirtuals() const | ||
| { | ||
| // Virtual columns can contain hive columns, so we remove these hive coulmns to avoid duplicates. |
There was a problem hiding this comment.
iirc, that wasn't supposed to be the case
2 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix cluster functions with hive partitioning
Documentation entry for user-facing changes
Solved #1855
List of virtual columns can include hive columns.
In non-cluster case iterator is created with filtered list of hive columns, where virtual columns columns are removed (see https://github.com/Altinity/ClickHouse/blob/antalya-26.3/src/Storages/prepareReadingFromFormat.cpp#L49).
In cluster case iterator was created with full lists. As result, hive columns added twice, later first column was filled with data, second was empty, and attempt to filter failed with error
SIZES_OF_COLUMNS_DOESNT_MATCH,CI/CD Options
Exclude tests:
Regression jobs to run: