Repository navigation
feat: Handle FMS (/allen/programs) paths - #508
Open
ShrimpCryptid wants to merge 2 commits into
Open
ShrimpCryptid wants to merge 2 commits into
ShrimpCryptid wants to merge 2 commits into
Conversation
toloudis
approved these changes
Nov 13, 2026
toloudis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, both my comments are nits
| }); | ||
|
|
||
| it("maps FMS file paths", () => { | ||
| expect(remapUri("/allen/programs/allencell/data/proj0/folder/some-data.ome.zarr")).toBe( |
Contributor
There was a problem hiding this comment.
is it possible someone coming from a Windows'y world would put this in with a double-forward-slash at the beginning? or do we handle that elsewhere?
Contributor
Author
There was a problem hiding this comment.
We do handle this in vole-app currently, yes. I could also copy in the code that handles that if we want to repeat it in both places.
| // remap /allen/aics/... to https://vast-files.int.allencell.org/... | ||
| newUrl = newUrl.replace(VAST_FILES_PREFIX, VAST_FILES_URL); | ||
| } else if (newUrl.startsWith(FMS_FILES_PREFIX)) { | ||
| // remap /allen/programs/allencell/data/proj0/... to https://s3.us-west-2.amazonaws.com/production.files.allencell.org/... |
Contributor
There was a problem hiding this comment.
I'm not sure if this comment is really adding value 🥲 . I might consider "remap absolute FMS filepaths to urls", and even with that, it's kinda easy to get that from what the code says.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adds support for remapping FMS paths to their S3 bucket equivalent.
Estimated review size: tiny, 5 minutes