Repository navigation
Reset to crop - #506
Open
frasercl wants to merge 2 commits into
Open
Reset to crop#506frasercl wants to merge 2 commits into
frasercl wants to merge 2 commits into
Conversation
| const scale = normPhysicalSize.clone().multiply(normRegionSize).multiply(this.settings.scale); | ||
| // center of the clip bounds, in the volume's normalized [-0.5, 0.5] local space | ||
| const boundsCenter = this.settings.bounds.bmin.clone().add(this.settings.bounds.bmax).multiplyScalar(0.5); | ||
| return boundsCenter.multiply(scale).add(this.childObjectsGroup.position); |
Contributor
There was a problem hiding this comment.
Why add childObjectsGroup here?
Contributor
There was a problem hiding this comment.
Is it meant to be a proxy for the volume center?
interim17
approved these changes
Nov 12, 2026
interim17
left a comment
There was a problem hiding this comment.
Also curious about Peyton's question, but seems good!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review time: small (~10-15min)
Resolves AllenCell/vole-app#496: by default,
resetCameranow resets to look at the center of the clipped subregion, not the center of the volume's bounding boxSteps to verify: