Repository navigation
add app id to viewport of main.rs - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Missing app icon in dock/dash on Linux using RPM or AppImage. fixes #24
Quality level L3 (see SKILLS/nc-devx/SKILL.md)
mainand has no merge commits (the pre-push hook checks this)cargo xtask cipasses (the pre-push hook and CI run it)coveragejob's warnings are read;cargo xtask coverage --updateis inthis pull request if coverage rose
docs/commands.md(regenerated),docs/gaps.md,docs/testing.md,docs/mcp.md,docs/control-protocol.md, as they applyCommandSpecwith a testcargo xtask demo-check, the format parity test, and a side byside look at both formats
cargo xtask screenshotsif they changedassets/ordocs/images/have a row inATTRIBUTION.mdHow it was checked
visually see screenshot