[Common] Minor fix to the FwdTrackExtensionTask#15835
Draft
lucamicheletti93 wants to merge 4 commits intoAliceO2Group:masterfrom
Draft
[Common] Minor fix to the FwdTrackExtensionTask#15835lucamicheletti93 wants to merge 4 commits intoAliceO2Group:masterfrom
lucamicheletti93 wants to merge 4 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 1 errors, |
| o2::track::TrackParCovFwd mft{mfttrack.z(), tpars, tcovs, mfttrack.chi2()}; | ||
| fwdtrack = o2::aod::fwdtrackutils::refitGlobalMuonCov(propmuon, mft); | ||
| } | ||
| if (trackType == o2::aod::fwdtrack::ForwardTrackTypeEnum::MuonStandaloneTrack || trackType == o2::aod::fwdtrack::ForwardTrackTypeEnum::MCHStandaloneTrack) { |
Contributor
There was a problem hiding this comment.
I have a doubt regarding the logic here... how do you compute the DCA in the case of trackType == GlobalMuonTrack || trackType == GlobalForwardTrack?
Thanks!
Collaborator
Author
There was a problem hiding this comment.
@aferrero2707 , I move back to a minimal fix configuration. Indeed with this change we reduce by half the memory consumption for this task (~450MB --> ~200MB), but I think we can go down to ~40MB with other modifications. I will work on that at the beginning of the week, for the moment I fix the issue with the geometry to avoid further issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix to reduce the memory consumption of the task