Skip to content

[PWGEM] Track matching checks for phosElId.cxx#15820

Merged
dsekihat merged 2 commits intoAliceO2Group:masterfrom
yhambard:master
Apr 17, 2026
Merged

[PWGEM] Track matching checks for phosElId.cxx#15820
dsekihat merged 2 commits intoAliceO2Group:masterfrom
yhambard:master

Conversation

@yhambard
Copy link
Copy Markdown
Contributor

@yhambard yhambard commented Apr 16, 2026

Added several cases, to see how the track matching changes - for TPC identified electrons
for True electrons (from mc)
for good dispersed clusters
for E/p ratio being around 1.05
and for all the combinations of the listed above

@yhambard
Track matching checks for phosElId.cxx
83ad9fd 
Added several cases, to see how the track matching changes - 
for TPC identified electrons
for True electrons (from mc)
for good dispersed clusters
for E/p ratio being around 1.05
and for all the combinations of the listed above
@github-actions github-actions bot added the pwgem label Apr 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Track matching checks for phosElId.cxx [PWGEM] Track matching checks for phosElId.cxx Apr 16, 2026
@yhambard yhambard marked this pull request as ready for review April 16, 2026 20:06
@yhambard yhambard marked this pull request as draft April 16, 2026 21:01
@yhambard yhambard marked this pull request as ready for review April 16, 2026 21:01
@yhambard yhambard marked this pull request as draft April 16, 2026 21:08
@yhambard yhambard marked this pull request as ready for review April 16, 2026 21:09
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 17, 2026

Error while checking build/O2Physics/o2 for 83ad9fd at 2026-04-17 06:35:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@yhambard
Copy link
Copy Markdown
Contributor Author

yhambard commented Apr 17, 2026 •
edited
Loading

@alibuild @feisenhu @dsekihat @jokonig @hscheid,
Could I, please, get a review to merge?
The macOS build fails on the protobuf package, it doesn't get to check my code. It isn't a required check.
Thanks in advance!

mhemmer-cern
mhemmer-cern reviewed Apr 17, 2026
View reviewed changes
Comment thread PWGEM/Tasks/phosElId.cxx Outdated
@yhambard
Revert back to angle brackets for includes phosElId.cxx
e12f55f 
Reverted back the includes to the ones changed on Apr 1 
[PWGEM] Fix includes and using statements (AliceO2Group#15385)
@dsekihat dsekihat merged commit 2738997 into AliceO2Group:master Apr 17, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhemmer-cern mhemmer-cern mhemmer-cern left review comments

@dsekihat dsekihat dsekihat approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhambard @alibuild @dsekihat @mhemmer-cern