[PWGDQ] Fill q-vector tables for all PbPb process functions in tableMaker_withAssoc#15741
[PWGDQ] Fill q-vector tables for all PbPb process functions in tableMaker_withAssoc#15741Ankyyadav wants to merge 5 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 87 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#15741
github-actions
bot
added
pwghf
Ankyyadav
changed the title
Please consider the following formatting changes to AliceO2Group#15741
Ankyyadav
force-pushed
the
QvectorANDFT0CcumulantsInMakerAssoc
branch
from
3d99fa1 to
1ca705c
Compare
github-actions
bot
removed
pwghf
Please consider the following formatting changes to AliceO2Group#15741
…on to fill Qvector tables for Dielectrons. Fill RefFlow and QvectorExtra table with FT0C cumulants if the cfgFT0CCumulant is true.
…cessPbPbWithFilterBarrelOnly). Added a configurable for Qvector calibration path. The tables shall only be filled if the calibrations are available
Ankyyadav
force-pushed
the
QvectorANDFT0CcumulantsInMakerAssoc
branch
from
7342e54 to
4ee4ed2
Compare
…hAssoc. Just use a bool configurable to check if they exist
Ankyyadav
requested review from
alibuild,
iarsene,
lucamicheletti93 and
mcoquet642
as code owners
| Produces<ReducedMFTsExtra> mftTrackExtra; | ||
| Produces<ReducedMFTAssoc> mftAssoc; | ||
|
|
||
| // Q-vector related tables, to be filled only if the user selects the corresponding option; since they are not needed for the skimming, we keep them in a separate group to avoid filling them when not needed |
There was a problem hiding this comment.
I would remove for the momento the q-vecotrs calculated by the CF framework. We need more tests to validate it properly
There was a problem hiding this comment.
Okay, I would remove the cumulant related tables and the part where I compute it. Though I do not use the GFW to fill these tables. I just need the FT0C amplitudes that I get from collisions tables.
Would it work if I add the FT0C cumulant part in dqFlow and a new process along with the existing processAllQvector and processQvecterFromCenter?
There was a problem hiding this comment.
@Ankyyadav maybe it is better to keep all the cumulant part in the dqFlow, and fully integrate it in the table-maker in a second moment
|
Dear @Ankyyadav , thanks for the PR! I think that for the moment you can remove the part for the cumulants. We need more test on the memory and on the consistency of the results. My suggestion is to just add the process function to include the filling of the q-vecotor tables when you use central barre j/psi. |
3 participants
Q-vector tables are to be filled in tableMaker_withAssoc now rather than using dqFlow to save memory. For all PbPb barrel processes, q-vector tables are filled now except for processPbPbWithFilterBarrelOnly. Added a cofigurable to check if q-vector calibrations exist.
For flow analysis using 2 particle correlations at midrapidity, one needs the RefFlow table filled with sum of squares of amplitude from FT0C. These are also filled. Switched to using a Produces group for all q-vector related tables