Skip to content

[PWGDQ] Add QA matching derived tables AO2D outputs#15517

Open
nivram-phy wants to merge 33 commits intoAliceO2Group:masterfrom
nivram-phy:PWGDQ-QAMatchingDerivedTable
Open

[PWGDQ] Add QA matching derived tables AO2D outputs#15517
nivram-phy wants to merge 33 commits intoAliceO2Group:masterfrom
nivram-phy:PWGDQ-QAMatchingDerivedTable

Conversation

@nivram-phy
Copy link
Copy Markdown
Contributor

This PR extends qaMatching.cxx to produce QA-focused AO2D tables and improves true-match indexing logic to use track-type–based muon selection. Add AOD schema and producers for QAMEVT, QAMCHTRK, and QAMCAND.

QAMEVT
Event-level summary: reduced event ID, MFT multiplicity, and collision vertex position.
QAMCHTRK
Per-MCH track info: track ID/type, kinematics, vertex-propagated params, and MFT matching attempts.
QAMCAND
Per-candidate info: matching label, parent track ID/kinematics, match type, score, and rank.

@github-actions github-actions bot added the pwgdq label Mar 25, 2026
@github-actions github-actions bot changed the title Add QA matching derived tables AO2D outputs [PWGDQ] Add QA matching derived tables AO2D outputs Mar 25, 2026
@nivram-phy nivram-phy marked this pull request as ready for review March 26, 2026 14:31
@ariffero
Copy link
Copy Markdown
Contributor

@ariffero Here is our pull request for your review

Hi @nivram-phy, I think that you tagged the wrong Andrea

@vkucera vkucera marked this pull request as draft March 26, 2026 16:02
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 4665baf at 2026-03-26 17:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15517-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:1712:17: error: unused variable 'mftTrack' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

Niveditha Ramasubramanian added 2 commits March 30, 2026 11:53
Comment thread PWGDQ/Tasks/qaMatching.cxx
nivram-phy and others added 4 commits April 17, 2026 13:59
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
Niveditha Ramasubramanian added 2 commits April 17, 2026 14:33
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 17, 2026

You can just run the linter and formatting locally and fix all issues at once before you push an update.

@nivram-phy
Copy link
Copy Markdown
Contributor Author

nivram-phy commented Apr 17, 2026

@vkucera I couldn't do it locally or understand where it was failing, so I am doing it this way. I am on very unfamiliar territory here.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 17, 2026

@vkucera I couldn't do it locally or understand where it was failing, so I am doing it this way. I am on very unfamiliar territory here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 25eedc6 at 2026-04-17 15:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2069:33: error: unused parameter 'verbose' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

Niveditha Ramasubramanian added 2 commits April 17, 2026 15:26
@nivram-phy nivram-phy requested a review from vkucera April 17, 2026 13:44
vkucera
vkucera previously approved these changes Apr 17, 2026
@vkucera vkucera marked this pull request as ready for review April 17, 2026 15:23
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 7c063a9 at 2026-04-17 17:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2064:34: error: assignment of member 'matchRanking' in read-only object
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2065:38: error: assignment of member 'matchRankingProd' in read-only object
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2066:31: error: assignment of member 'QaMatching::MatchingCandidate::matchType' in read-only object
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2067:41: error: assignment of member 'QaMatching::MatchingCandidate::mftMchMatchAttempts' in read-only object
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2084:33: error: unused parameter 'verbose' [-Werror=unused-parameter]
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_algo.h:1782:24: error: passing 'const QaMatching::MatchingCandidate' as 'this' argument discards qualifiers [-fpermissive]
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_heap.h:263:17: error: passing 'const QaMatching::MatchingCandidate' as 'this' argument discards qualifiers [-fpermissive]
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_algobase.h:185:11: error: no matching function for call to 'swap(const QaMatching::MatchingCandidate&, const QaMatching::MatchingCandidate&)'
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/type_traits:138:11: error: no type named 'type' in 'struct std::enable_if<false, void>'
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_heap.h:235:36: error: passing 'const QaMatching::MatchingCandidate' as 'this' argument discards qualifiers [-fpermissive]
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_heap.h:241:36: error: passing 'const QaMatching::MatchingCandidate' as 'this' argument discards qualifiers [-fpermissive]
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_algobase.h:750:25: error: passing 'const QaMatching::MatchingCandidate' as 'this' argument discards qualifiers [-fpermissive]
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_algobase.h:766:40: error: invalid conversion from 'const void*' to 'void*' [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft April 17, 2026 15:39
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 17, 2026

You didn't test your changes before pushing.

@nivram-phy nivram-phy marked this pull request as ready for review April 17, 2026 17:15
@nivram-phy
Copy link
Copy Markdown
Contributor Author

@vkucera I noticed that macOS-arm and o2 check seems to happen only if the PR is not in draft, is that correct or maybe I haev misunderstood it?

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 17, 2026

@vkucera I noticed that macOS-arm and o2 check seems to happen only if the PR is not in draft, is that correct or maybe I haev misunderstood it?

It's correct. We don't compile draft PRs.

@nivram-phy
Copy link
Copy Markdown
Contributor Author

@aferrero2707 Back to a stable point, needed to fix a lot of things as some baseline linter requirements have changed.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 17, 2026

@aferrero2707 Back to a stable point, needed to fix a lot of things as some baseline linter requirements have changed.

@nivram-phy What do you mean? No requirements have changed since you opened the PR.

@nivram-phy
Copy link
Copy Markdown
Contributor Author

@aferrero2707 Back to a stable point, needed to fix a lot of things as some baseline linter requirements have changed.

@nivram-phy What do you mean? No requirements have changed since you opened the PR.

@vkucera We were working with a different version of the code from a month ago locally for building a derived table table. From that point, the include files were modified in the master that I had not noticed. This is what I mentioned.
Maybe my wording could have been better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants