Conversation
This fixes the millisecond rounding of the TF-aligned ITS ramp-up shift, updates the ramp-up test to the new signature and clears the remaining Pylint error. - The ramp-up is now rounded up to whole milliseconds before it is rounded up to whole TFs, so the shifted timestamp can no longer lie inside the ramp. - test_anchoring_rampup.py passes the TF length to shift_anchor_past_ITS_rampup and has a regression test for a ramp ending just below a TF boundary. - ccdb_cross_check in getCCDBTimeMachineTimestamp.py keeps the pinned object in a local variable, which Pylint can follow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the millisecond rounding of the TF-aligned ITS ramp-up shift from #2489, updates its test to the new signature and clears the remaining Pylint error.
test_anchoring_rampup.pypasses the TF length toshift_anchor_past_ITS_rampup, checks that the orbit shift is a multiple of the TF length, and has a regression test for the case above.ccdb_cross_checkingetCCDBTimeMachineTimestamp.pykeeps the pinned object in a local variable, which Pylint can follow.Assisted by Claude Code.