Skip to content

Rename default database schema to research #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabbypolito wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename default database schema to research #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion algosystem/backtesting/infrastructure/persistence/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class DatabaseConfig:
database: str
user: str
password: str
schema: str = "backtest"
schema: str = "research"
pool_size: int = 5

def __post_init__(self) -> None:
Expand Down
2 changes: 1 addition & 1 deletion algosystem/backtesting/infrastructure/persistence/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from algosystem.shared.errors import ConfigurationError
from algosystem.shared.metric_key import MetricKey

DEFAULT_SCHEMA = "backtest"
DEFAULT_SCHEMA = "research"
_IDENTIFIER_RE = re.compile(r"^[A-Za-z_][A-Za-z0-9_]*$")

Base = declarative_base()
Expand Down
2 changes: 1 addition & 1 deletion tests/backtesting/infrastructure/persistence/test_config_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def test_database_config_from_env_is_explicit_and_redacts_password():

assert config.host == "localhost"
assert config.port == 5432
assert config.schema == "backtest"
assert config.schema == "research"
assert config.url() == "postgresql://tester:secret@localhost:5432/algosystem"
assert "secret" not in repr(config)
assert "<redacted>" in repr(config)
Expand Down
Loading