Skip to content

refactor: updated nosv createExecutionUnit signature to use replicableFc_t #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lterrac merged 2 commits into from
Apr 29, 2026
Merged

refactor: updated nosv createExecutionUnit signature to use replicableFc_t #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15d3ccf
refactor: updated nosv createExecutionUnit signature to use replicabl…
lterrac Apr 29, 2026
324c02a
fix: adjust aclMock include path
lterrac Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 extern/aclMock/acl/acl.h → extern/aclMock/include/acl/acl.h
View file
Open in desktop
File renamed without changes.
0 extern/aclMock/acl/acl_base.h → extern/aclMock/include/acl/acl_base.h
View file
Open in desktop
File renamed without changes.
0 extern/aclMock/acl/acl_mdl.h → extern/aclMock/include/acl/acl_mdl.h
View file
Open in desktop
File renamed without changes.
0 extern/aclMock/acl/acl_op.h → extern/aclMock/include/acl/acl_op.h
View file
Open in desktop
File renamed without changes.
0 extern/aclMock/acl/acl_op_compiler.h → extern/aclMock/include/acl/acl_op_compiler.h
View file
Open in desktop
File renamed without changes.
0 extern/aclMock/acl/acl_rt.h → extern/aclMock/include/acl/acl_rt.h
View file
Open in desktop
File renamed without changes.
0 extern/aclMock/acl/acl_rt_allocator.h → ...rn/aclMock/include/acl/acl_rt_allocator.h
View file
Open in desktop
File renamed without changes.
0 .../aclMock/acl/error_codes/ge_error_codes.h → .../include/acl/error_codes/ge_error_codes.h
View file
Open in desktop
File renamed without changes.
0 .../aclMock/acl/error_codes/rt_error_codes.h → .../include/acl/error_codes/rt_error_codes.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion extern/aclMock/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ project(

# HiCR acl Mock Backend Configuration

backendIncludes = include_directories(['.'])
backendIncludes = include_directories(['include'])

aclDependency = declare_dependency(
sources: ['acl.cpp'],
Expand Down
2 changes: 1 addition & 1 deletion include/hicr/backends/nosv/computeManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class ComputeManager : public HiCR::ComputeManager
* \param[in] executionUnit The replicable function to execute
* @return The newly created execution unit
*/
__INLINE__ std::shared_ptr<HiCR::ExecutionUnit> createExecutionUnit(const std::function<void(void *)> &executionUnit) override
__INLINE__ std::shared_ptr<HiCR::ExecutionUnit> createExecutionUnit(const replicableFc_t &executionUnit) override
{
return std::make_shared<HiCR::backend::nosv::ExecutionUnit>(executionUnit);
}
Expand Down
Loading