Skip to content

feat: drag to reorder rules #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ravian18 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: drag to reorder rules #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e8ce26
fix: drop non-existent scrollEdgeEffectDisabled call that breaks buil…
Apr 20, 2026
5dd8edc
feat: drag to reorder rules
Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Browserino/Extensions/View+ScrollEdgeDisabled.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ extension View {
@ViewBuilder
func scrollEdgeEffectDisabledCompat() -> some View {
if #available(macOS 26.0, *) {
self
.scrollEdgeEffectStyle(.soft, for: .all)
.scrollEdgeEffectDisabled(true, for: .all)
self.scrollEdgeEffectStyle(.soft, for: .all)
} else {
self
}
Expand Down
11 changes: 8 additions & 3 deletions Browserino/Views/Preferences/RulesTab.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,11 @@ struct RuleItem: View {

struct RulesTab: View {
@AppStorage("rules") private var rules: [Rule] = []


private func move(from source: IndexSet, to destination: Int) {
rules.move(fromOffsets: source, toOffset: destination)
}

var body: some View {
VStack (alignment: .leading) {
List {
Expand All @@ -97,9 +101,10 @@ struct RulesTab: View {
rule: rule
)
}
.onMove(perform: move)
}
Text("Type regex and choose app in which links will be opened without prompt")

Text("Drag and drop to reorder. Type regex and choose app in which links will be opened without prompt. The first matching rule wins.")
.font(.subheadline)
.foregroundStyle(.primary.opacity(0.5))
.frame(maxWidth: .infinity)
Expand Down