Skip to content

fix(roadmap-planner): 2026–2027 quarters + center modals on viewport - #214

Merged
danielfbm merged 2 commits into
mainfrom
fix/roadmap-planner-quarters-modal-center
Oct 19, 2026
Merged

danielfbm merged 2 commits into
mainfrom
fix/roadmap-planner-quarters-modal-center

Conversation

@danielfbm

@danielfbm danielfbm commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Quarters

  • Default jira.quarters is now 2026Q1–2027Q4: the 2025 quarters are removed, the missing 2026Q3 is added, and all of 2027 is added.
  • API.md example updated to match.
  • Note: a deployed config.yaml that sets jira.quarters still overrides this default.

Modals centered on the page instead of the viewport

  • Cause: .fade-in (on .kanban-container) used animation-fill-mode: both, which left transform: translateY(0) on the container after the animation ended. A transformed ancestor becomes the containing block for position: fixed descendants, so .modal-overlay covered and centered on the whole board, not the viewport.
  • Fix: .fade-in now uses backwards. It looks the same and no transform is left behind. This also covers the metrics dashboard, which uses the same class.
  • Safeguard: the five board modals are rendered through createPortal into document.body.

CI unblock (both gates were already red on main)

  • gofmt -s on internal/contributions/bot_test.go and service.go (alignment only).
  • npm audit --audit-level high: ran npm audit fix (axios, form-data, js-yaml, brace-expansion, browserslist, @babel/core), and bumped dev tooling vite 5→7, vitest 2→5 and @vitejs/plugin-react 4→5 to clear tinypool (critical) and esbuild. vite.config.js is unchanged; npm audit reports 0 vulnerabilities.

Test plan

  • go build ./... and go test ./... pass (87 tests)
  • Frontend: vitest run (14 passed), vite build and npm run lint pass locally; npm audit reports 0 vulnerabilities
  • Manual: scroll down a long board, open the create/edit milestone and epic modals, and check that each one is centered in the viewport
  • Manual: the quarter selector lists 2026Q1–2027Q4

🤖 Generated with Claude Code

https://claude.ai/code/session_013PC6xooXDx54eqGrW7zCMv

danielfbm and others added 2 commits October 19, 2026 10:04
- Default jira.quarters is now 2026Q1–2027Q4: drop 2025, add the
  missing 2026Q3, and add all of 2027.
- .fade-in used animation-fill-mode `both`, which left
  `transform: translateY(0)` on .kanban-container. A transformed
  ancestor becomes the containing block for position:fixed
  descendants, so modal overlays centered on the whole board instead
  of the viewport. Switch to `backwards`, and portal the board modals
  to document.body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013PC6xooXDx54eqGrW7zCMv
- gofmt -s two files in internal/contributions (alignment only); the
  backend gofmt gate was already red on main.
- npm audit fix for runtime/transitive advisories (axios, form-data,
  js-yaml, brace-expansion, browserslist, @babel/core).
- Bump dev toolchain vite 5 -> 7, vitest 2 -> 5,
  @vitejs/plugin-react 4 -> 5 to clear tinypool (critical) and
  esbuild advisories. vite.config.js is unchanged; tests, build and
  lint pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013PC6xooXDx54eqGrW7zCMv
@danielfbm
danielfbm merged commit 38d5e0a into main Oct 19, 2026
12 checks passed
@danielfbm
danielfbm deleted the fix/roadmap-planner-quarters-modal-center branch October 19, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant