Repository navigation
fix(widget): get_parent returns pointer instead of reference - #49
Merged
Merged
Conversation
this makes it more safe if, for example: _parent == nullptr because nullptr would've been derefrenced.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Updates Widget::get_parent() to return a nullable pointer, safely supporting root widgets without parents.
Changes:
- Changes the return type from reference to pointer.
- Returns
_parentdirectly.
File summaries
| File | Summary |
|---|---|
Source/Widgets/ctui_widget.h |
Updates the public API return type. |
Source/Widgets/ctui_widget.cpp |
Returns the nullable parent pointer safely. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
this makes it more safe if, for example: _parent == nullptr because nullptr would've been derefrenced.
Widget::get_parent() didnt have usages yet so no calls were changed.