[codex] Add Button loading state#222
Draft
vku2018 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #72
Summary
Buttonprimitive disable itself whileloadingis true.Spinnerinside loading buttons while preserving button children.aria-busyon loading buttons and add regression coverage for default, loading, and explicitly disabled states.Validation
npm ci --ignore-scripts --no-auditnpm test -- src/components/__tests__/Button.test.tsx src/components/__tests__/Spinner.test.tsx(5 passing)npx eslint src/components/Button.tsx src/components/__tests__/Button.test.tsxgit diff --checknpm run typecheckwas attempted and is blocked by unrelated existing errors insrc/app/agents/[agent]/page.tsx(Breadcrumb,formatRequests) andsrc/app/docs/page.tsx(safeHref).