Switching floors from outside takes you into that floor's elevator - #193
Merged
Merged
Conversation
Picking a floor from the project list keeps you on the same spot. Out on the street, the balcony, the golf course or down in the garage, that spot looks the same on every floor, so switching seemed to do nothing. From outside the office it now rides the elevator and you step out of that floor's car. Indoors it still keeps your spot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out on the street, the balcony, the golf course or down in the garage, picking another project from the floor list in the top-left corner looked like it did nothing.
Why: the floor list keeps you on the same spot on the other floor. Outside the office's walls, that spot looks the same on every floor. The street, the golf course and the balcony are identical, so you stayed outside with only the name in the corner changing.
Now: if you're outside the office on your floor, picking a floor rides the elevator. The lights dip, then you step out of that floor's car with the doors opening and a ding, the same as the elevator panel does from anywhere. Inside the office (the back office too, as far as it's built out), switching still keeps your spot. The roof and maps of their own work as before.
src/client/main.ts: newindoors()(within the office's walls at floor level, or in the built-out back office).switchFloorhands off toride()when you're outside.src/client/ui/floormenu.ts: from outside, the floor item's tooltip says "Go to X, in its elevator" instead of "right where you're standing".docs/features.md: the floor-list paragraph describes what happens from outside.Verification
npm run typecheck,npm run buildandnpm test(411/411) all pass.floors.jsonfixture), using__office.switchFloor:🤖 Generated with Claude Code