Repository navigation
ci: verify user paths and fail incomplete OSV scans - #112
Merged
Merged
Conversation
brian93512
marked this pull request as ready for review
October 13, 2026 02:55
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSV query failures were silently discarded, allowing incomplete vulnerability checks to produce successful security reports. Scans now return an explicit incomplete error when any dependency query fails; CLI produces no success report, MCP JSON scans return tool errors, and gate refuses installation even with --force.
Adds User-path Verification to every PR, including stacked bases, and main/master/dev pushes. The job builds current binaries, runs baseline/discovery/OSV drives, cleans the owned runtime, and uploads evidence for 14 days even after failures.
The local OSV HTTP fixture covers clean/vulnerable responses, 503, 429, malformed/null JSON, partial dependency failures, timeouts, MCP errors, and unchanged gate config with a local lockfile. TOOLTRUST_OSV_URL supports trusted OSV-compatible endpoints; HTTPS is required except numeric loopback HTTP. There is no fallback on endpoint failure. Full scan failure is deliberate: OSV outages can prevent scans with dependencies, rather than assigning a misleading grade.
Validation: full Go race suite, golangci-lint, actionlint, five baseline features, thirteen discovery probes, and the OSV drive passed locally. Test artifacts are retained outside the repository. The User-path Verification job also passed on GitHub; full CI and security checks run against main.
Merge after #111. MCP HTTP transport is explicitly deferred; this PR tests OSV HTTP integration, not MCP HTTP support. Full inventory completeness, live public OSV availability, deep scan and real npm/Claude installation are outside this change.