a11y: make comment permalink button keyboard-visible and named - #67
Open
waterlemonnn wants to merge 1 commit into
Open
a11y: make comment permalink button keyboard-visible and named#67waterlemonnn wants to merge 1 commit into
waterlemonnn wants to merge 1 commit into
Conversation
CommentAnchorLink only revealed on hover, so a focused button had no visible indicator (WCAG 2.4.7), and its accessible name was the "#" character via title. Add focus-visible:opacity-100, swap title for aria-label, hide the glyph from assistive tech, and announce the copied state via a live region.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
CommentAnchorLinkincomponents/post/CommentsSection.tsxwas only revealed ongroup-hover, so a keyboard user tabbing to it focused an invisible control with no visible focus indicator (WCAG 2.4.7). Its accessible name was also just the#character viatitle, which isn't a reliable accessible name and isn't surfaced on touch/keyboard.focus-visible:opacity-100alongside the existinggroup-hover:opacity-100so focus reveals the button.titlewitharia-label="Copy link to this comment", and wrapped the visible#/Copiedglyph inaria-hidden="true".aria-live="polite"sr-onlyspan that announces "Copied" when the state flips, so screen reader users get feedback too.Test plan
npm run lint— cleannpx tsc --noEmit— cleannpx vitest run— 87/87 passing (no existing coverage for this component)