fix: handle clipboard write failures in copy-link buttons - #66
Open
waterlemonnn wants to merge 1 commit into
Open
fix: handle clipboard write failures in copy-link buttons#66waterlemonnn wants to merge 1 commit into
waterlemonnn wants to merge 1 commit into
Conversation
navigator.clipboard.writeText() rejects on insecure origins, unfocused documents, or denied permission. Both CopyLinkButton and CommentAnchorLink now await the call in a try/catch and surface a failure state instead of unconditionally claiming success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
CopyLinkButtonandCommentAnchorLinkcallednavigator.clipboard.writeText()without awaiting or catching it, then unconditionally setcopiedto true.writeTextrejects on insecure origins, unfocused documents, or denied clipboard permission, so the UI could claim success while nothing was actually copied.Changes
asyncandawaitwriteTextinsidetry/catch.failedstate and render a short message instead of "Copied" (CopyLinkButtonshows "Could not copy, copy the URL from the address bar";CommentAnchorLinkshows "Failed" given its compact#-sized layout).navigator.clipboardbeing undefined before calling it.Checklist
next lint,tsc --noEmit,vitest run(87/87) all cleanCloses #123)Closes #27