fix(pagination): announce state to screen readers - #64
Open
waterlemonnn wants to merge 1 commit into
Open
Conversation
The pagination row had no landmark, page links all read the same, and Prev/Next disabled states were opacity-only visual cues.
|
Welcome, @waterlemonnn, and thanks for your first pull request to agentpostmortem. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
components/ui/Pagination.tsxgave screen reader users no way to tell what the row was, which page was current, or that the Prev/Next placeholders were disabled (opacity-only visual cue).divto<nav aria-label="Pagination">aria-current="page"to the current page's<Link>aria-label={\Page ${p}`}` to each page link…spansaria-hidden="true"aria-disabled="true"to the disabled Prev/Next spansNo visual change. Ran
npx prettier --write .(no-op),npm run lint,npx tsc --noEmit, andnpx vitest run(87 passed) locally.