chore(ci): drop Node 18 from the test matrix - #18
Merged
Conversation
Node 18 reached end of life in April 2025, so the matrix was spending a third of its jobs on a runtime nothing should still be running. It was also the job most often starved of a runner, and a matrix job that never gets one is reported as a cancelled run, which turns the whole build red and sends a failure email for a green codebase. engines.node moves to >=20 in the same commit. Dropping a version from CI while still advertising support for it in package.json would mean claiming a runtime we no longer test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 18 went end of life in April 2025.
Two reasons to drop it now rather than later:
cancelled, and a cancelled job turns the whole run red. That is what produced the failure email onmaintoday, on a codebase where Node 20 and 22 both passed.engines.nodemoves to>=20in the same commit, because dropping a version from CI while still advertising it inpackage.jsonwould mean claiming support for a runtime we no longer test.Verified locally: full suite, lint and typecheck pass.