fix(action): reference a tag that exists - #20
Merged
Conversation
Both the README and the example workflow told consumers to use AgentPostmortem/evalgate@v1. No v1 tag has ever existed, so the job failed at 'Set up job' before running anything, and the workflow in this repo has never once succeeded. Anyone copying the README snippet, which explicitly invites them to, got the same broken run. Points at @v0 instead. A moving major tag is the Actions convention, and v0 is the honest one to publish while the package is 0.1.x: cutting v1 would advertise a stability guarantee this does not have yet. Also tags v0.1.1 to match the version already on npm, which shipped without a git tag.
action.yml ran 'npx --yes evalgate@latest'. Our package is published as @royalpinto007/evalgate, so the unscoped name resolves to an unrelated package owned by someone else, currently evalgate@3.2.0. That is why the gate failed even once the tag resolved: the other package requires Node >=22 and imports node:sqlite, so it crashed with ERR_UNKNOWN_BUILTIN_MODULE on the Node 20 runner. The more serious half is supply chain. This action is documented as something to drop into any consuming repo, so every consumer's CI was downloading and executing a third party package we do not control, under their GITHUB_TOKEN. The README already uses the scoped name everywhere. Only action.yml was wrong.
evalgate: support-agentPASS - No regressions detected. Overall score: 94.2% (base) -> 94.2% (head) = 0.0pp
All cases unchanged. tolerance 1.0% - worst case 0.0pp Posted by evalgate - the build fails when your prompt gets dumber. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README and the example workflow both point at
AgentPostmortem/evalgate@v1. That tag has never existed, so the action cannot resolve and the job dies atSet up job.Consequences:
evalgateworkflow in this repo has never succeeded. Not once.Now points at
@v0, andv0is published as a moving major tag atmain.Chose
v0overv1deliberately: the package is0.1.1, and cutting av1action tag would advertise a stability guarantee that does not exist yet. Moving to@v1is the right call at 1.0.Also tagged
v0.1.1, which was published to npm without a git tag.