Repository navigation
fix: an exiting daemon removes only its own socket (0.3.5) - #22
Merged
Merged
Conversation
Record the Unix socket's device and inode when it is bound, and at shutdown remove the path only while it still names that socket. A daemon that outlived its client used to unlink the socket a newer daemon had bound at the same path, which left the newer one listening, holding the lock, and unreachable. Idle, signalled and requested shutdowns all go through the same check; Windows is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
A
furrow servedaemon that outlived its client removed its socket path when it idled out, even if a newer daemon had since bound that same path. Afterwards the newer daemon kept listening and kept holding the lock, but no client could reach it: every dial failed withno such file or directory, and a freshly started daemon found the lock held and exited at once. codeaf hit this in a two-computer test (Agent-Field/CodeAF#1982).What changed
Tests
furrow-daemon/tests/socket_cleanup.rs(Unix only):Three of these failed before the fix.
🤖 Generated with Claude Code