Repository navigation
test: set the mode the portable exchange test asserts - #18
Merged
Merged
Conversation
The test asserts a new file captures as 0644 but relied on the runner's umask, so it fails under a 0002 umask (fleet jobs). Set the mode explicitly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
let mut repository = FurrowRepository::open_composed_in(&data, &root, None) fs::write(root.join("new"), b"new\r\n").unwrap(); +fs::set_permissions(root.join("new"), Permissions::from_mode(0o644)) // unix only repository.snapshot(...) assert_eq!(new.mode & 0o777, 0o644);The test asserts a freshly written file captures as
0644but depended on the runner's umask.Evidence
w3_linux_exchange_preserves_bytes_paths_and_recorded_modesfails under umask 002 (the fleet runner's):left: 436, right: 420, on unmodified main.After: passes under umask 002 and umask 022 on Spark.
Merge Danger
Door: two-way. Test-only change.
Blast Radius: none outside this one test.