Repository navigation
fix(doctor): recommend current Anthropic and Google models - #1133
pcbeingused333 wants to merge 2 commits into
Conversation
af doctor suggested claude-3-5-sonnet-20241022 and gemini-1.5-pro as the AI_MODEL for an Anthropic or Google key; both models are retired, so a scaffold that follows the recommendation fails on its first call. Recommend claude-sonnet-5-5 and gemini-3.8-flash, and update the commented examples in the docker .env template. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
santoshkumarradha
left a comment
There was a problem hiding this comment.
Thanks for updating these recommendations. The Google change is current, but the Anthropic model ID needs one small correction before this can land.
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
AbirAbbas
left a comment
There was a problem hiding this comment.
Both suggested models check out (details in the doctor.go thread), the doctor tests pass, and CI is green. The one leftover retired-model mention is the claude-3-sonnet example in the Python AIConfig.model description, which is out of scope here.
Summary
af doctorsuggests anAI_MODELfor whichever provider key it finds, and for Anthropic and Google it suggestedclaude-3-5-sonnet-20241022andgemini-1.5-pro. Both models are retired (claude-3-5-sonnetwas retired on 2025-10-28 per Anthropic's model deprecations; no Gemini 1.5 model is listed any more on the Gemini API models page), so a scaffold that follows the recommendation fails on its first model call. The recommendation is nowclaude-sonnet-5-5andgemini-3.8-flash(the current stable Flash model), and the commented examples in the docker.envtemplate and theaf init --default-modelhelp text match.The
gpt-4osuggestion for OpenAI is left as it is.Type of change
Test plan
cd control-plane && go test ./internal/cli ./internal/templatesrecommended models are not retired onesindoctor_additional_test.gosets only the Anthropic (then only the Google) key and checks the recommended model. It fails onmainwith the retired IDs and passes with this change.Test coverage
Checklist
This change was prepared with Claude Code.