Skip to content

Add MiniMax voice design support - #1108

Closed
octo-patch wants to merge 1 commit into
Agent-Field:mainfrom
octo-patch:octo/20261017-voice-design-tool-recvvbQ9RhTI4R
Closed

octo-patch wants to merge 1 commit into
Agent-Field:mainfrom
octo-patch:octo/20261017-voice-design-tool-recvvbQ9RhTI4R

Conversation

@octo-patch

Copy link
Copy Markdown
Contributor

Reason: MiniMaxProvider supports regional voice cloning and text-to-speech but lacks the voice design transport and response handling.

Add a regional MiniMax voice design operation that sends prompt and voice_id to /v1/voice_design, validates status responses, and returns the designed voice ID. Add unit coverage for global and China endpoints, request fields, validation, and API errors.

Checks: sdk/python/.venv/bin/pytest -q tests/test_minimax_voice_design.py tests/test_minimax_voice_clone.py

@octo-patch
octo-patch requested review from a team and AbirAbbas as code owners October 17, 2026 12:36
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown
Contributor

Performance

SDK Memory Δ Latency Δ Tests Status
Python 9.1 KB - 0.33 µs -6% ✓ ✓

✓ No regressions detected

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage gate

Thresholds from .coverage-gate.toml: per-surface ≥ 84%, aggregate ≥ 85%, max per-surface regression ≤ 1.0 pp, max aggregate regression ≤ 0.50 pp.

Surface Current Baseline Δ
control-plane 88.00% 87.40% ↑ +0.60 pp 🟡
sdk-go 93.30% 92.00% ↑ +1.30 pp 🟢
sdk-python 94.72% 93.73% ↑ +0.99 pp 🟢
sdk-typescript 91.77% 90.42% ↑ +1.35 pp 🟢
web-ui 84.76% 84.79% ↓ -0.03 pp 🟡
aggregate 85.95% 85.75% ↑ +0.20 pp 🟡

✅ Gate passed

No surface regressed past the allowed threshold and the aggregate stayed above the floor.

@github-actions

Copy link
Copy Markdown
Contributor

📐 Patch coverage gate

Threshold: 80% on lines this PR touches vs origin/main (from .coverage-gate.toml:thresholds.min_patch).

Surface Touched lines Patch coverage Status
control-plane 0 — ➖ no changes
sdk-go 0 — ➖ no changes
sdk-python 0 — ➖ no changes
sdk-typescript 0 — ➖ no changes
web-ui 0 — ➖ no changes

✅ Patch gate passed

Every surface whose lines were touched by this PR has patch coverage at or above the threshold.

@AbirAbbas

Copy link
Copy Markdown
Contributor

Reminder that the CLA needs to be signed before this can merge: https://cla-assistant.io/Agent-Field/agentfield?pullRequest=1108

It may already be signed on your side. The commit here is authored as Octopatch <octopatch@users.noreply.github.com>, and that address isn't linked to any GitHub account, so CLA assistant can't match it to you. Your other PR (#1112) uses 266937838+octo-patch@users.noreply.github.com and passes. Re-authoring this commit with that address and pushing should clear the check.

@AbirAbbas

Copy link
Copy Markdown
Contributor

Closing this since the CLA check still isn't passing. As mentioned above, the commit is authored as octopatch@users.noreply.github.com, which isn't linked to your account. Once the commit uses an address CLA assistant can match (like the one on #1112) and the check is green, leave a comment and we'll reopen it.

@AbirAbbas AbirAbbas closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants