Repository navigation
Mac push: Tests use the physical temporary folder on macOS (from #2033) #2050
Description
This draft was closed, unmerged, when the 2026-10-29 Mac stability and performance push was stopped early to save usage. Its branch is kept: reopen the PR or start from the branch, rebase onto the latest base, and finish the steps below.
PR: #2033 (tests: fixtures get the physical temporary folder on macOS)
Branch: test/canonical-temp-roots
What it fixes. Test-only. About 101 tests failed on macOS because TMPDIR lives under /var, a link to /private/var, and paths were compared as spelled. A TestMain helper gives the affected packages the physical temporary root. The branch also carries fixes for tests that change exposed: a tui3 label test now draws a frame its project fits in, and cmd/codeaf's short state roots start at /private/tmp so engine-host sockets stay under macOS's 104-byte limit. Those last two fixes are pushed but not yet verified.
Done. Helper and package hooks; rebased onto app/v3 7e40a79.
Left. Targeted runs and a full Mac go test ./... vs base; CI comparison; a Codex round on the final diff. #2047 builds on it.
🤖 Generated with Claude Code
Activity
AbirAbbas commentedon Nov 2, 2026
Merged in #2033 (squash 91bfa14 on app/v3), rebased onto app/v3 f7422fb. CI on the rebased head (PR gate and Full check) failed only on tests that also fail on the app/v3 baseline, or that flaked on unrelated branches in the same rounds. Code review of the rebased head: no findings. Not yet exercised on a real Mac: the macOS branch of the helper (physical temporary root) runs only in a Mac test run; on Linux it is a no-op.