Skip to content

Mac push: Engine-backed sync fixtures for macOS (from #2032) #2049

Closed

Description

@AbirAbbas

This draft was closed, unmerged, when the 2026-10-29 Mac stability and performance push was stopped early to save usage. Its branch is kept: reopen the PR or start from the branch, rebase onto the latest base, and finish the steps below.

PR: #2032 (tests: the engine-backed sync fixtures speak, wait for their branches, and read the Mac chord)
Branch: test/sync-fixtures-real-engine

What it fixes. Test-only. Fourteen furrow-backed sync tests always failed on macOS because of stale fixtures: chat.say must append an assistant line, three branch tests must wait for the branch row and orphan count, and cmd/codeaf tests must draw the take chord with the platform helper. Linux CI stages no furrow, so these tests only run where furrow is staged.

Done. Fixture fixes; rebased onto app/v3 7e40a79.

Left. A full Mac go test ./... with furrow staged on the rebased head vs base, by test name; CI comparison; a Codex round after the rebase.


🤖 Generated with Claude Code

Activity

  1. AbirAbbas commented on Nov 3, 2026

    @AbirAbbas
    CollaboratorAuthor

    Merged via #2032 (app/v3 e1a3692). After rebasing onto app/v3, #2178 and #2183 already covered most of the branch. What's left: short Unix socket homes for the hosted move rig and the drive rig's default daemon, plus the L12 branch-publication wait. On macOS 15.6 arm64, TestDriveSidePublishesOverTheDefaultDaemon and TestTwoHomesL12DeathBranches pass 6/6 on the branch, while unchanged app/v3 fails 3 of 6. The 21 cmd/codeaf tests that use the hosted move rig pass 63/63. CI has nothing beyond the app/v3 baseline except flakes that passed on a rerun of the same SHA or also fail on unrelated branches. Codex review clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:testsThe suite itself — flakes, harnesses, laws, CI redsbugSomething the code does that it should not

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions