Skip to content

Define the GuildPass SDK V2 public domain types #488

Closed

Description

@Lakes41

Difficulty

Medium

Type

Architecture / SDK

Background

GuildPass SDK V2 should expose a stable, developer-facing representation of the platform without leaking Core implementation details or frontend-specific assumptions.

Problem

The rebuilt SDK has a clean foundation, but it still needs a canonical public type surface for Guilds, Members, Passes, access decisions, activity events, Stellar accounts, and supported networks.

Expected Outcome

The SDK exports a coherent set of public V2 types aligned with GuildPass Core while remaining suitable for external consumers.

Suggested Implementation

  • Define public SDK types for Guild, Member, Pass, AccessPolicy, AccessDecision, ActivityEvent, StellarAccount, and Network.
  • Align the public type shapes with the canonical Core domain contracts.
  • Avoid exposing internal Core persistence or service implementation details.
  • Remove EVM-oriented terminology and address assumptions.
  • Use Stellar-first naming and account representations.
  • Export the public types through the package entry point.

Acceptance Criteria

  • Public V2 domain types are defined.
  • Types are aligned with Core contracts.
  • No database-specific types are exported.
  • No frontend-specific types are exported.
  • No EVM-specific account assumptions remain.
  • Stellar network and account concepts are represented clearly.
  • Public types are exported from the SDK package entry point.
  • Typecheck and tests pass.

Likely Affected Files/Directories

  • src/types/
  • src/index.ts
  • test/

Activity

  1. added
    Third CampaignOfficial FWC26 campaign issue — eligible for campaign scoring and rewards
    on Sep 12, 2026
  2. abojeEdwin commented on Sep 12, 2026

    @abojeEdwin

    Hi maintainer, I've gone through the issue and I have a clear understanding of the fix for this issue. I'd love to be assigned to this issue. Thank you

  3. guptakumarranjeet150 commented on Sep 15, 2026

    @guptakumarranjeet150
    Contributor

    Hello @maintainers,

    I would love to take this on. My planned approach:

    • Build Define the GuildPass SDK V2 public domain types with responsive React/Next.js components and clean state management.
    • Verify UI performance and zero console errors.

    Ready to deliver a clean, tested PR within 12–24 hours. Please assign!

  4. grantfox-oss commented on Sep 17, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @rupesh-kumar-sah's PR #506 was approved and merged by @Lakes41.

    🏆 @rupesh-kumar-sah: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (140 total points). Track your full progress on GrantFox.

    👏 Great work, @rupesh-kumar-sah! Keep contributing to Adamantine-guild.

  5. added a commit that references this issue on Oct 19, 2026
    063270d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Third CampaignOfficial FWC26 campaign issue — eligible for campaign scoring and rewards

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions