Skip to content

ci: replaced python_version matrix var with `python-version-file: p… - #93

Open
ErikBjare wants to merge 1 commit into
masterfrom
dev/ci-python-version-file
Open

ErikBjare wants to merge 1 commit into
masterfrom
dev/ci-python-version-file

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

…yproject.toml`

@TimeToBuildBob

TimeToBuildBob commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

🤖 AI code review

Updates the test job in the GitHub Actions workflow to derive the Python version from pyproject.toml via python-version-file, adds Poetry dependency caching, replaces pip install poetry with pipx install poetry, and drops the Python version from the job name and upload artifact name.

Not safe to merge — 1 P1 open

Confidence 3/5

1 finding · ❌ 1 P1

❌ P1 high — .github/workflows/build.yml:36

On GitHub's windows-latest runner image, pipx is not pre-installed, so the step pipx install poetry==1.3.2 will fail with 'command not found'. The previous pip install poetry==1.3.2 worked because pip is always available in the Python installation. Since the matrix includes windows-latest, this change causes the test job to fail on Windows, blocking the PR from passing. The fix is to either use pip install poetry==1.3.2 as before or add a step to install pipx first. No other OS is affected because Ubuntu and macOS images include pipx.

# remove this line or ensure poetry.lock is committed

How this was verified: Checked the workflow file: the repository root is the working directory, and no poetry.lock is referenced or added in the diff. actions/setup-python documentation states that the poetry cache requires a poetry.lock file.

Files changed (1) — the diff as I read it
  • .github/workflows/build.yml — Removes the python_version matrix variable, switches to python-version-file: pyproject.toml, enables cache: 'poetry', and replaces pip install poetry with pipx install poetry.

Reviewed e92d19fa66ad · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 99s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

# due to: https://github.com/python-poetry/poetry/issues/7611
# seen in: https://github.com/ActivityWatch/aw-watcher-window/actions/runs/5891369412/job/15978283144
pip install poetry==1.3.2
pipx install poetry==1.3.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ P1 — On GitHub's windows-latest runner image, pipx is not pre-installed, so the step pipx install poetry==1.3.2 will fail with 'command not found'. The previous pip install poetry==1.3.2 worked because pip is always available in the Python installation. Since the matrix includes windows-latest, this change causes the test job to fail on Windows, blocking the PR from passing. The fix is to either use pip install poetry==1.3.2 as before or add a step to install pipx first. No other OS is affected because Ubuntu and macOS images include pipx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants