Repository navigation
Conversation
🤖 AI code reviewUpdates the test job in the GitHub Actions workflow to derive the Python version from Not safe to merge — 1 P1 openConfidence 3/5 1 finding · ❌ 1 P1❌ P1 high — On GitHub's How this was verified: Checked the workflow file: the repository root is the working directory, and no poetry.lock is referenced or added in the diff. actions/setup-python documentation states that the poetry cache requires a poetry.lock file. Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
| # due to: https://github.com/python-poetry/poetry/issues/7611 | ||
| # seen in: https://github.com/ActivityWatch/aw-watcher-window/actions/runs/5891369412/job/15978283144 | ||
| pip install poetry==1.3.2 | ||
| pipx install poetry==1.3.2 |
There was a problem hiding this comment.
❌ P1 — On GitHub's windows-latest runner image, pipx is not pre-installed, so the step pipx install poetry==1.3.2 will fail with 'command not found'. The previous pip install poetry==1.3.2 worked because pip is always available in the Python installation. Since the matrix includes windows-latest, this change causes the test job to fail on Windows, blocking the PR from passing. The fix is to either use pip install poetry==1.3.2 as before or add a step to install pipx first. No other OS is affected because Ubuntu and macOS images include pipx.
…yproject.toml`