Skip to content

feat: review button in plugin page #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadlyjack merged 1 commit into from
Sep 22, 2026
Merged

feat: review button in plugin page #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/pages/plugin/plugin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,48 @@
margin: 0 auto;
box-sizing: border-box;

&.has-reviews-button #plugin-tab .tab-content {
padding-bottom: calc(88px + env(safe-area-inset-bottom));
}

.plugin-reviews-button {
Comment thread
deadlyjack marked this conversation as resolved.
position: fixed;
inset-inline-end: calc(20px + max(env(safe-area-inset-left), env(safe-area-inset-right)));
bottom: calc(20px + env(safe-area-inset-bottom));
z-index: 2;
display: inline-flex;
align-items: center;
justify-content: center;
gap: 8px;
min-width: 48px;
min-height: 48px;
max-width: calc(100% - 40px - env(safe-area-inset-left) - env(safe-area-inset-right));
padding: 12px 20px;
box-sizing: border-box;
border: none;
border-radius: 24px;
background: var(--button-background-color);
color: var(--button-text-color);
box-shadow: 0 4px 12px var(--box-shadow-color);
font: inherit;
font-weight: 500;
line-height: 1.25;
text-transform: capitalize;
cursor: pointer;

&:focus-visible {
outline: 2px solid var(--button-background-color);
outline-offset: 4px;
}

.icon {
flex: 0 0 20px;
width: 20px;
height: 20px;
font-size: 20px;
}
}

.plugin-header {
display: grid;
grid-template-columns: auto 1fr auto;
Expand Down
38 changes: 25 additions & 13 deletions src/pages/plugin/plugin.view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ export default (props) => {
rating === "unrated" ? strings["plugin-review:unrated"] : rating;
const ratingValueRef = Ref();
const commentCountRef = Ref();
const hasReviews = votesUp !== undefined;

const keywords =
typeof keywordsRaw === "string" ? JSON.parse(keywordsRaw) : keywordsRaw;
Expand All @@ -108,6 +109,13 @@ export default (props) => {
ratingValueRef.className = getRatingClass(rating);
commentCountRef.textContent = reviewStats.commentCount;
};
const openReviews = () =>
showReviews({
pluginId: id,
author,
stats: reviewStats,
onStatsChange: applyReviewStats,
});

const formatUpdatedDate = (dateString) => {
if (!dateString) return null;
Expand All @@ -124,7 +132,10 @@ export default (props) => {
};

return (
<div className="main" id="plugin">
<div
className={`main${hasReviews ? " has-reviews-button" : ""}`}
id="plugin"
>
<div className="plugin-header">
<div
className="plugin-icon"
Expand Down Expand Up @@ -170,7 +181,7 @@ export default (props) => {
{license || "Unknown"}
</span>
</div>
{votesUp !== undefined ? (
{hasReviews ? (
<div className="metrics-row">
<div className="metric">
<span className="icon save_alt"></span>
Expand All @@ -189,17 +200,7 @@ export default (props) => {
{getRatingText()}
</span>
</div>
<div
className="metric"
onclick={() =>
showReviews({
pluginId: id,
author,
stats: reviewStats,
onStatsChange: applyReviewStats,
})
}
>
<div className="metric" onclick={openReviews}>
<i className="icon chat_bubble"></i>
<span ref={commentCountRef} className="metric-value">
{reviewStats.commentCount}
Expand Down Expand Up @@ -305,6 +306,17 @@ export default (props) => {
></div>
</div>
</TabView>
{hasReviews ? (
<button
type="button"
className="plugin-reviews-button"
aria-label={strings["plugin-review:dialog-label"]}
onclick={openReviews}
>
<span className="icon chat_bubble" aria-hidden="true"></span>
<span>{strings.reviews}</span>
</button>
) : null}
</div>
);
};
Expand Down
Loading