Skip to content

fix(fileIcons api): preserve sizing and folder state on plugin refresh - #2923

Merged
bajrangCoder merged 2 commits into
mainfrom
fix/file-icon-refresh
Sep 22, 2026
Merged

bajrangCoder merged 2 commits into
mainfrom
fix/file-icon-refresh

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported storage-color issue is fixed and no new actionable defects were identified.

Summary

This PR makes late plugin icon refreshes preserve File Browser sizing and storage-color hooks while correctly retaining closed-folder state.

  • Preserves the structural icon and user-added-storage classes when replacing resolved glyph classes.
  • Updates File Browser styling so storage color remains applicable after the built-in folder class is replaced.
  • Adds regression coverage for file sizing and closed storage-folder refresh behavior.
  • Strengthens existing highlighting and SFTP migration tests by asserting expected warnings.

Reviews (2) · Last reviewed commit: "fix"

Comment thread src/lib/fileIcons.ts
@bajrangCoder

Copy link
Copy Markdown
Member Author

@greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit b57a418 Sep 22, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Sep 22, 2026
@bajrangCoder
bajrangCoder deleted the fix/file-icon-refresh branch September 22, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant