fix: race condition when moving to exact line/col

[bajrangCoder]

No description provided.

[greptile-apps]

Greptile Summary

This PR makes project-search result navigation resilient to overlapping asynchronous file opens.

• Cancels obsolete navigation requests without waiting for their filesystem work to settle.
• Verifies the target file remains active and fully loaded before revealing the match.
• Reference-counts the shared title loader so overlapping opens cannot hide one another’s progress.
• Adds focused tests for cancellation, stale navigation, restored tabs, coordinate clamping, and concurrent loader ownership.

Confidence Score: 5/5

The PR appears safe to merge; the prior navigation-blocking issue is resolved, and the loader fix addresses the remaining overlapping-open feedback issue.

The previously resolved obsolete-request finding remains fixed because newer navigation starts immediately and stale work is prevented from activating or revealing a file. The outstanding loader finding is now fully fixed by reference-counting active loaders and making cancellation release idempotent, so an obsolete open cannot hide the latest operation’s indicator.

Important Files Changed

Filename	Overview
src/lib/openFile.js	Adds cancellation checkpoints and reference-counted title-loader ownership for concurrent file opens.
src/sidebarApps/searchInFiles/index.js	Delegates search-result opening and exact-range navigation to the new race-safe helper.
src/sidebarApps/searchInFiles/navigateToResult.js	Cancels obsolete requests and validates target identity and loading state before revealing a clamped range.
tests/unit/openFileCancellation.test.js	Covers cancellation across asynchronous stages and shared-loader behavior under overlapping opens.
tests/unit/searchResultNavigation.test.js	Covers latest-request behavior, restored tabs, stale targets, exact ranges, and recovery after failures.

Sequence Diagram

sequenceDiagram
    participant User
    participant Nav as navigateToResult
    participant Open as openFile
    participant Filesystem
    participant Editor

    User->>Nav: Select search result
    Nav->>Nav: Abort previous navigation
    Nav->>Open: Open target with AbortSignal
    Open->>Filesystem: Stat/read target
    User->>Nav: Select newer result
    Nav->>Nav: Abort obsolete signal
    Nav->>Open: Open newer target
    Open-->>Nav: Newer target activated
    Nav->>Editor: Load and verify active file
    Nav->>Editor: Reveal exact range
    Filesystem-->>Open: Obsolete operation settles
    Open-->>Nav: Discard obsolete result

Loading

_{Reviews (3): Last reviewed commit: "fix(search): preserve loader during conc..." | Re-trigger Greptile}