Skip to content

fix: preserve MIME type for plugin icons on plugin details page #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 2 commits into from
Aug 27, 2026
Merged

fix: preserve MIME type for plugin icons on plugin details page #2818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fc7a89
fix: preserve MIME type for plugin icons on plugin details page
bajrangCoder Aug 27, 2026
711d270
fix
bajrangCoder Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/plugin/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import anchor from "markdown-it-anchor";
import markdownItFootnote from "markdown-it-footnote";
import MarkdownItGitHubAlerts from "markdown-it-github-alerts";
import markdownItTaskLists from "markdown-it-task-lists";
import mimeTypes from "mime-types";
import { highlightCodeBlock, initHighlighting } from "utils/codeHighlight";
import helpers from "utils/helpers";
import Url from "utils/Url";
Expand Down Expand Up @@ -120,8 +121,10 @@ export default async function PluginInclude(
Url.join(PLUGIN_DIR, id, installedPlugin.icon),
);
const iconData = await fsOperation(iconUrl).readFile();
const iconMimeType =
mimeTypes.lookup(installedPlugin.icon) || "image/png";
const icon = URL.createObjectURL(
new Blob([iconData], { type: "image/png" }),
new Blob([iconData], { type: iconMimeType }),
);
Comment thread
bajrangCoder marked this conversation as resolved.
plugin = {
id,
Expand Down